Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error msg when geometry is not supported in GeoJSON #4006

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

mmomtchev
Copy link
Contributor

Transform CPLDebug into CPLError

Rationale:
This is a serious error condition that causes the function to fail and to set a null geometry for the feature
Without it, a NULL geometry is returned and there is no LastErrorMsg

It doesn't break any unit tests

Refs: #4004

@rouault rouault merged commit df70f89 into OSGeo:master Jun 17, 2021
a0x8o added a commit to a0x8o/gdal that referenced this pull request Jun 17, 2021
* 'master' of github.com:OSGeo/gdal:
  GeoJSON writer: emit error msg when geometry type is not supported in GeoJSON (OSGeo#4006)
  GTiff signedbyte: do not write 0 values for tiles/strips entirely at a negative nodata value (fixes OSGeo#3984)
@mmomtchev mmomtchev deleted the geojson_err_report branch August 8, 2021 20:39
a0x8o added a commit to a0x8o/gdal that referenced this pull request Jun 6, 2022
* 'master' of github.com:OSGeo/gdal:
  GeoJSON writer: emit error msg when geometry type is not supported in GeoJSON (OSGeo#4006)
  GTiff signedbyte: do not write 0 values for tiles/strips entirely at a negative nodata value (fixes OSGeo#3984)
a0x8o added a commit to a0x8o/gdal that referenced this pull request Jun 10, 2022
* 'master' of github.com:OSGeo/gdal:
  GeoJSON writer: emit error msg when geometry type is not supported in GeoJSON (OSGeo#4006)
  GTiff signedbyte: do not write 0 values for tiles/strips entirely at a negative nodata value (fixes OSGeo#3984)
a0x8o added a commit to a0x8o/gdal that referenced this pull request Jun 15, 2022
* 'master' of github.com:OSGeo/gdal:
  GeoJSON writer: emit error msg when geometry type is not supported in GeoJSON (OSGeo#4006)
  GTiff signedbyte: do not write 0 values for tiles/strips entirely at a negative nodata value (fixes OSGeo#3984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants